Re: [PATCH v1] vhost_vdpa: fix the problem in vhost_vdpa_set_config_call

[Jason Wang]

On 2021/1/12 上午10:46, Cindy Lu wrote:

in vhost_vdpa_set_config_call, the cb.private should be vhost_vdpa.

Should be "In"

this cb.private will finally use in vhost_vdpa_config_cb as
vhost_vdpa.Fix this issue

An whitespace is needed before Fix and a full stop after "issue"

Fixes: 776f395004d82 ("vhost_vdpa: Support config interrupt in vdpa")

Acked-by: Jason Wang <jasow...@redhat.com>

Please post a V2 with the above fixed and cc stable.

Thanks

Signed-off-by: Cindy Lu <l...@redhat.com>
---
  drivers/vhost/vdpa.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
index ef688c8c0e0e..3fbb9c1f49da 100644
--- a/drivers/vhost/vdpa.c
+++ b/drivers/vhost/vdpa.c
@@ -319,7 +319,7 @@ static long vhost_vdpa_set_config_call(struct vhost_vdpa 
*v, u32 __user *argp)
        struct eventfd_ctx *ctx;

cb.callback = vhost_vdpa_config_cb;

-       cb.private = v->vdpa;
+       cb.private = v;
        if (copy_from_user(&fd, argp, sizeof(fd)))
                return  -EFAULT;