On Mon, Jan 04, 2021 at 02:02:13PM -0800, Dmitry Torokhov wrote: > On Tue, Dec 29, 2020 at 01:15:10PM +0530, Souptick Joarder wrote: > > On Tue, Dec 22, 2020 at 1:34 AM Souptick Joarder <[email protected]> > > wrote: > > > > > > Kernel test robot throws below warning -> > > > > > > >> drivers/input/misc/ariel-pwrbutton.c:152:35: warning: unused variable > > > >> 'ariel_pwrbutton_id_table' [-Wunused-const-variable] > > > static const struct spi_device_id ariel_pwrbutton_id_table[] = { > > > ^ > > > 1 warning generated. > > > > > > Remove unused variable ariel_pwrbutton_id_table[] if no plan to use > > > it further. > > > > > > Reported-by: kernel test robot <[email protected]> > > > Signed-off-by: Souptick Joarder <[email protected]> > > > > Any comment on this patch ? > > Lubomir, would you prefer to remove the table or add it to the driver > structure as ariel_pwrbutton_driver->id_table?
I believe it can be safely dropped, as the OF match seems to be sufficient. Thank you for the patch Souptick. Reviewed-by: Lubomir Rintel <[email protected]> > > Thanks. > > -- > Dmitry
