On Mon, Jan 11, 2021 at 01:44:09PM +0100, Rafael J. Wysocki wrote: > On Mon, Jan 11, 2021 at 8:40 AM Chen Yu <yu.c.c...@intel.com> wrote: > > > > Add input parameter to receive guarantee pstate from > > intel_pstate_get_hwp_max() > > for later use. > > I'm not a fan of this change, because the new argument will only be > needed in one place where intel_pstate_get_hwp_max() and it requires > adding redundant local vars and pointless updates elsewhere. > > Besides, in intel_pstate_get_cpu_pstates() you can do something like > this after calling intel_pstate_get_hwp_max(): > > cpu->pstate.max_pstate = HWP_GUARANTEED_PERF(READ_ONCE(cpu->hwp_cap_cached)); > cpu->pstate.max_freq = cpu->pstate.max_pstate * cpu->pstate.scaling; Okay, will do in next version.
Thanks, Chenyu
