On Wed, 13 Jan 2021 10:16:54 +0100
Alexander Potapenko <gli...@google.com> wrote:
> +DECLARE_EVENT_CLASS(error_report_template,
> + TP_PROTO(const char *error_detector, unsigned long id),
Instead of having a random string, as this should be used by a small finite
set of subsystems, why not make the above into an enum?
> + TP_ARGS(error_detector, id),
> + TP_STRUCT__entry(__field(const char *, error_detector)
> + __field(unsigned long, id)),
> + TP_fast_assign(__entry->error_detector = error_detector;
> + __entry->id = id;),
> + TP_printk("[%s] %lx", __entry->error_detector,
Then the [%s] portion of this could also be just a __print_symbolic().
-- Steve
> + __entry->id));
> +
> +/**
