On Thu, Jan 7, 2021 at 3:48 PM Daniel Latypov <dlaty...@google.com> wrote: > > The authors of this tool were more familiar with a different > type-checker, https://github.com/google/pytype. > > That's open source, but mypy seems more prevalent (and runs faster). > And unlike pytype, mypy doesn't try to infer types so it doesn't check > unanotated functions. > > So annotate ~all functions in kunit tool to increase type-checking > coverage. > Note: per https://www.python.org/dev/peps/pep-0484/, `__init__()` should > be annotated as `-> None`. > > Doing so makes mypy discover a number of new violations. > Exclude main() since we reuse `request` for the different types of > requests, which mypy isn't happy about. > > This commit fixes all but one error, where `TestSuite.status` might be > None. > > Signed-off-by: Daniel Latypov <dlaty...@google.com> > Reviewed-by: David Gow <david...@google.com>
Hey, I just tried applying this series as a pre-check before sending it off to Shuah and it no longer applies to torvalds/master. Please fix and resend.
