Re: [PATCH 2/3] dt-bindings: fpga: Add binding doc for versal fpga manager

[Michal Simek]

On 1/18/21 3:43 AM, Nava kishore Manne wrote:
> From: Appana Durga Kedareswara rao <appana.durga....@xilinx.com>
> 
> This patch adds binding doc for versal fpga manager driver.
> 
> Signed-off-by: Nava kishore Manne <nava.ma...@xilinx.com>
> Signed-off-by: Appana Durga Kedareswara rao <appana.durga....@xilinx.com>
> ---
>  .../bindings/fpga/xlnx,versal-fpga.yaml       | 33 +++++++++++++++++++
>  1 file changed, 33 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml
> 
> diff --git a/Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml 
> b/Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml
> new file mode 100644
> index 000000000000..cf3aa7917488
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml
> @@ -0,0 +1,33 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +
> +$id: http://devicetree.org/schemas/fpga/xilinx/xlnx,versal-fpga.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Xilinx versal-fpga driver.
> +
> +maintainers:
> +  - Nava kishore Manne <nava.ma...@xilinx.com>
> +
> +description: |
> +Device Tree versal-fpga bindings for the Versal SOC, Controlled
> +using Versal SoC firmware interface.
> +
> +properties:
> +  compatible:
> +    items:
> +      - enum:
> +        - xlnx,versal-fpga
> +
> +required:
> +  - compatible
> +
> +Required properties:
> +- compatible: should contain "xlnx,versal-fpga"
> +
> +examples:
> +  - |
> +    versal_fpga: fpga {
> +         compatible = "xlnx,versal-fpga";
> +    };
> 

There are issues with the binding
Run
make
DT_SCHEMA_FILES=Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml
dt_binding_check

and fix
./Documentation/devicetree/bindings/fpga/xlnx,versal-fpga.yaml:15:1:
[error] syntax error: could not find expected ':' (syntax)
and maybe others.

Thanks,
Michal