> -----Original Message----- > From: Greg KH <gre...@linuxfoundation.org> > Sent: Thursday, January 21, 2021 3:46 PM > To: 吳昊澄 Ricky <ricky...@realtek.com> > Cc: a...@arndb.de; ricky...@realtek.corp-partner.google.com; > sas...@kernel.org; levin...@google.com; keitasuzuki.p...@sslab.ics.keio.ac.jp; > kd...@doth.eu; linux-kernel@vger.kernel.org > Subject: Re: [PATCH] rtsx: pci: fix device aspm state bug > > On Thu, Jan 21, 2021 at 03:28:58PM +0800, ricky...@realtek.com wrote: > > From: Ricky Wu <ricky...@realtek.corp-partner.google.com> > > > > changed rtsx_pci_disable_aspm() to rtsx_disable_aspm() make sure > > pcr->aspm_enabled to sync with aspm state > > Can you make this a bit more descriptive? > Changed rtsx_pci_disable_aspm() to rtsx_disable_aspm() make sure pcr->aspm_enabled to sync with aspm state. rtsx_pci_disable_aspm() this function disable aspm by setting config space directly did not change value of pcr->aspm_enabled so changed to use rtsx_disable_aspm(). Give initial value to pcr->aspm_enabled by reading config space setting at init_hw().
> > > > > BUG=b:175338107 > > TEST=chromeos-kernel-5_4 > > What are these lines for? > > > > > Signed-off-by: Ricky Wu <ricky...@realtek.corp-partner.google.com> > > This email does not match your From: address :( > > > Change-Id: I4b146dcdaaf2f2a965381c32780b0b110d751258 > > Please use checkpatch.pl before sending patches to us :( > > And why did you send this twice? > > thanks, > > greg k-h > > ------Please consider the environment before printing this e-mail.
