On Thu, Jan 21, 2021 at 3:49 AM Linus Walleij <linus.wall...@linaro.org> wrote: > > Hi Mohamed, > > thanks for your patch! > > On Wed, Jan 20, 2021 at 2:31 PM Mohamed Mediouni > <mohamed.medio...@caramail.com> wrote: > > > +properties: > > + compatible: > > + items: > > + - const: apple,aic
As mentioned in patch 7, this needs to be SoC specific. Also, bindings should be separate patch. checkpatch.pl will tell you this. > However weird it may seem, Apple is not in the file > Documentation/devicetree/bindings/vendor-prefixes.yaml > > (I think it's weird because I remember clearly that they have been > using device tree for PPC since ages.) That's because the vendor prefix is 'AAPL' which is the stock ticker and it predates documenting anything. > Could you add this 2-liner to that file and send it directly to > DT binding maintainers as a single patch as a preparation? So this is still needed. Happy to take that given already in use. Rob