[Re: [PATCH RFC cpumask] Allow "all", "none", and "last" in cpumask strings] On 20/01/2021 (Wed 23:11) Yury Norov wrote:
> Hi Paul, > > Today I found this series in linux-next despite downsides discovered during > the review. This series introduces absolutely unneeded cap on the number of > cpus in the system (9999), and also adds unsafe and non-optimal code. > > In addition to that, I observe this warning on powerpc: > CC lib/cpumask.o > lib/cpumask.c: In function ‘cpulist_parse’: > lib/cpumask.c:222:17: warning: cast from pointer to integer of > different size [-Wpointer-to-int-cast] > 222 | memblock_free((phys_addr_t)cpulist, len); > | ^ > > Can you please revert this series unless all the problems will be fixed? That was my fault - I should have explicitly asked PaulM to yank it once I didn't get to creating v2 immediately. Sorry. Your suggested changes made things much more simple and smaller - thanks! I believe v2 does address all the problems - please have a look when you have some time. It should be easier to review, given the smaller size. https://lore.kernel.org/lkml/20210121223355.59780-1-paul.gortma...@windriver.com/ Thanks again, Paul. -- > > Thanks, > Yury
