Re: [PATCH v4 06/17] selftests/resctrl: Check for resctrl mount point only if resctrl FS is supported

[Shuah Khan]

On 11/30/20 1:19 PM, Fenghua Yu wrote:

check_resctrlfs_support() does the following
1. Checks if the platform supports resctrl file system or not by looking
    for resctrl in /proc/filesystems
2. Calls opendir() on default resctrl file system path
    (i.e. /sys/fs/resctrl)
3. Checks if resctrl file system is mounted or not by looking at
    /proc/mounts

Steps 2 and 3 will fail if the platform does not support resctrl file
system. So, there is no need to check for them if step 1 fails.

Fix this by returning immediately if the platform does not support
resctrl file system.

Signed-off-by: Fenghua Yu <fenghua...@intel.com>
---
  tools/testing/selftests/resctrl/resctrlfs.c | 3 +++
  1 file changed, 3 insertions(+)

diff --git a/tools/testing/selftests/resctrl/resctrlfs.c 
b/tools/testing/selftests/resctrl/resctrlfs.c
index 2c574d143ff0..c676557b376d 100644
--- a/tools/testing/selftests/resctrl/resctrlfs.c
+++ b/tools/testing/selftests/resctrl/resctrlfs.c
@@ -579,6 +579,9 @@ bool check_resctrlfs_support(void)
        printf("%sok kernel supports resctrl filesystem\n", ret ? "" : "not ");

Same comment. Please use kselftest API in kselftest.h for TAP.

        tests_run++;

+ if (!ret)

+               return ret;
+
        dp = opendir(RESCTRL_PATH);
        printf("%sok resctrl mountpoint \"%s\" exists\n",
               dp ? "" : "not ", RESCTRL_PATH);

Same comment. Please use kselftest API in kselftest.h for TAP.

Otherwise looks good.

thanks,
-- Shuah