Hi Oleksij, I love your patch! Yet something to improve:
[auto build test ERROR on robh/for-next] [also build test ERROR on v5.11-rc5 next-20210125] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Oleksij-Rempel/add-support-for-GPIO-based-counter/20210127-085034 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: i386-allyesconfig (attached as .config) compiler: gcc-9 (Debian 9.3.0-15) 9.3.0 reproduce (this is a W=1 build): # https://github.com/0day-ci/linux/commit/39e2c0023dba4e0e0f2bb9bfa1caeadb40df6356 git remote add linux-review https://github.com/0day-ci/linux git fetch --no-tags linux-review Oleksij-Rempel/add-support-for-GPIO-based-counter/20210127-085034 git checkout 39e2c0023dba4e0e0f2bb9bfa1caeadb40df6356 # save the attached .config to linux build tree make W=1 ARCH=i386 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot <l...@intel.com> All errors (new ones prefixed by >>): drivers/counter/pulse-cnt.c: In function 'pulse_cnt_probe': >> drivers/counter/pulse-cnt.c:205:2: error: implicit declaration of function >> 'irq_set_status_flags' [-Werror=implicit-function-declaration] 205 | irq_set_status_flags(priv->irq, IRQ_NOAUTOEN); | ^~~~~~~~~~~~~~~~~~~~ >> drivers/counter/pulse-cnt.c:205:34: error: 'IRQ_NOAUTOEN' undeclared (first >> use in this function) 205 | irq_set_status_flags(priv->irq, IRQ_NOAUTOEN); | ^~~~~~~~~~~~ drivers/counter/pulse-cnt.c:205:34: note: each undeclared identifier is reported only once for each function it appears in cc1: some warnings being treated as errors vim +/irq_set_status_flags +205 drivers/counter/pulse-cnt.c 168 169 static int pulse_cnt_probe(struct platform_device *pdev) 170 { 171 struct device *dev = &pdev->dev; 172 struct pulse_cnt_priv *priv; 173 int ret; 174 175 priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL); 176 if (!priv) 177 return -ENOMEM; 178 179 priv->irq = platform_get_irq(pdev, 0); 180 if (priv->irq < 0) { 181 dev_err(dev, "failed to map GPIO to IRQ: %d\n", priv->irq); 182 return priv->irq; 183 } 184 185 priv->gpio = devm_gpiod_get_optional(dev, NULL, GPIOD_IN); 186 if (IS_ERR(priv->gpio)) 187 return dev_err_probe(dev, PTR_ERR(priv->gpio), "failed to get gpio\n"); 188 189 priv->ops.action_get = pulse_cnt_action_get; 190 priv->ops.count_read = pulse_cnt_read; 191 priv->ops.count_write = pulse_cnt_write; 192 priv->ops.function_get = pulse_cnt_function_get; 193 if (priv->gpio) 194 priv->ops.signal_read = pulse_cnt_signal_read; 195 196 priv->counter.name = dev_name(dev); 197 priv->counter.parent = dev; 198 priv->counter.ops = &priv->ops; 199 priv->counter.counts = pulse_cnts; 200 priv->counter.num_counts = ARRAY_SIZE(pulse_cnts); 201 priv->counter.signals = pulse_cnt_signals; 202 priv->counter.num_signals = ARRAY_SIZE(pulse_cnt_signals); 203 priv->counter.priv = priv; 204 > 205 irq_set_status_flags(priv->irq, IRQ_NOAUTOEN); 206 ret = devm_request_irq(dev, priv->irq, pulse_cnt_isr, 207 IRQF_TRIGGER_RISING | IRQF_NO_THREAD, 208 PULSE_CNT_NAME, priv); 209 if (ret) 210 return ret; 211 212 platform_set_drvdata(pdev, priv); 213 214 return devm_counter_register(dev, &priv->counter); 215 } 216 --- 0-DAY CI Kernel Test Service, Intel Corporation https://lists.01.org/hyperkitty/list/kbuild-...@lists.01.org
.config.gz
Description: application/gzip
