On Wed, Feb 3, 2021 at 6:20 AM Kefeng Wang <wangkefeng.w...@huawei.com> wrote: > > The numa feature is useless for riscv32 platform(MAXPHYSMEM_1GB if 32bit), > and it should depends on SMP feature, this also fix the build error, > > riscv64-buildroot-linux-gnu-ld: mm/page_alloc.o: in function `.L0 ': > page_alloc.c:(.text+0x4808): undefined reference to `node_reclaim_distance' >
Thanks for the fix. The commit text is a bit ambiguous. The compilation issue error is due to SMP. RV32 dependency is just another fix as NUMA is not very useful for RV32. > Fixes: 4f0e8eef772e ("riscv: Add numa support for riscv64 platform") > Signed-off-by: Kefeng Wang <wangkefeng.w...@huawei.com> > --- > arch/riscv/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig > index 22fa17898d29..ac7f5801bd82 100644 > --- a/arch/riscv/Kconfig > +++ b/arch/riscv/Kconfig > @@ -312,6 +312,8 @@ endchoice > # Common NUMA Features > config NUMA > bool "NUMA Memory Allocation and Scheduler Support" > + depends on SMP > + depends on 64BIT > select GENERIC_ARCH_NUMA > select OF_NUMA > select ARCH_SUPPORTS_NUMA_BALANCING > -- > 2.26.2 > > > _______________________________________________ > linux-riscv mailing list > linux-ri...@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-riscv Reviewed-by: Atish Patra <atish.pa...@wdc.com> -- Regards, Atish