On Tue, Feb 02, 2021, Ben Gardon wrote: > @@ -505,8 +516,8 @@ static bool zap_gfn_range(struct kvm *kvm, struct > kvm_mmu_page *root, > > tdp_mmu_set_spte(kvm, &iter, 0); > > - flush_needed = !can_yield || > - !tdp_mmu_iter_cond_resched(kvm, &iter, true); > + flush_needed = !(can_yield && > + tdp_mmu_iter_cond_resched(kvm, &iter, true));
Unnecessary change to convert perfectly readable code into an abomination :-D No need to "fix", it goes aways in the next patch anyways, I just wanted to complain. > } > return flush_needed; > } > -- > 2.30.0.365.g02bc693789-goog >
