Hi Daniel, On Fri, 5 Feb 2021 at 23:06, Daniel Thompson <daniel.thomp...@linaro.org> wrote: > > On Thu, Feb 04, 2021 at 03:44:20PM +0530, Sumit Garg wrote: > > @@ -318,6 +318,65 @@ int kdbgetintenv(const char *match, int *value) > > } > > > > /* > > + * kdb_setenv() - Alter an existing environment variable or create a new > > one. > > + * @var: Name of the variable > > + * @val: Value of the variable > > + * > > + * Return: Zero on success, a kdb diagnostic on failure. > > + */ > > +static int kdb_setenv(const char *var, const char *val) > > +{ > > + int i; > > + char *ep; > > + size_t varlen, vallen; > > + > > + varlen = strlen(var); > > + vallen = strlen(val); > > + ep = kdballocenv(varlen + vallen + 2); > > + if (ep == (char *)0) > > + return KDB_ENVBUFFULL; > > + > > + sprintf(ep, "%s=%s", var, val); > > + > > + ep[varlen+vallen+1] = '\0'; > > What is this line for? It looks pointless to me. >
Yeah, it looks redundant to me as well. > I know it's copied from the original code but it doesn't look like the > sort of code you should want your name to appear next to in a git blame > ;-) . > Sure, let me get rid of it in v3. -Sumit > > Daniel.