On Tue, Feb 09, 2021 at 11:06:41AM -0800, Linus Torvalds wrote: > So I'm looking at this early, because I have more time now than I will > have during the merge window, and honestly, your pull requests have > been problematic in the past.
Thanks for looking at this early. > The PG_fscache bit waiting functions are completely crazy. The comment > about "this will wake up others" is actively wrong, and the waiting > function looks insane, because you're mixing the two names for > "fscache" which makes the code look totally incomprehensible. Why > would we wait for PF_fscache, when PG_private_2 was set? Yes, I know > why, but the code looks entirely nonsensical. Yeah, I have trouble with the private2 vs fscache bit too. I've been trying to persuade David that he doesn't actually need an fscache bit at all; he can just increment the page's refcount to prevent it from being freed while he writes data to the cache. > But the thing that makes me go "No, I won't pull this", is that it has > all the same hallmark signs of trouble that I've complained about > before: I see absolutely zero sign of "this has more developers > involved". I've been involved! I really want to get rid of the address_space readpages op. The only remaining users are the filesystems which use fscache and it's hard to convert them with the old infrastructure. I'm not 100% convinced that the new infrastructure is good, but I am convinced that it's better than the old infrastructure. > There's not a single ack from a VM person for the VM changes. There's > no sign that this isn't yet another "David Howells went off alone and > did something that absolutely nobody else cared about". I'm pretty bad about sending R-b for patches when I've only given them a quick once-over. I tend to only do it for patches that I've given an appropriately deep amount of thought to (eg almost none for spelling fixes and days for page cache related patches). I'll see what I feel comfortable with for this patchset. > See my problem? I need to be convinced that this makes sense outside > of your world, and it's not yet another thing that will cause problems > down the line because nobody else really ever used it or cared about > it until we hit a snag. My major concern is that we haven't had any feedback from Trond or Anna. I don't know if they're just too busy or if there's something else going on, but it'd be nice to hear something.
