Hi,
Thanks for your review.
On Fri, Feb 12, 2021 at 10:32:09AM +0100, Arnd Bergmann wrote:
> On Fri, Feb 12, 2021 at 4:03 AM Nobuhiro Iwamatsu
> <nobuhiro1.iwama...@toshiba.co.jp> wrote:
> > @@ -384,6 +398,16 @@ spi6: spi@28146000 {
> > #size-cells = <0>;
> > status = "disabled";
> > };
> > +
> > + piether: ethernet@28000000 {
> > + compatible = "toshiba,visconti-dwmac";
>
> Shouldn't there be a more specific compatible string here, as well as the
> particular version of the dwmac you use?
I rechecked the code again based on your point.
I need to specify the version of dwmac. I also noticed that it could
remove some unnecessary code. I will fix this.
>
> In the binding example, you list the device as "dma-coherent",
> but in this instance, it is not marked that way. Can you find out
> whether the device is in fact connected properly to a cache-coherent
> bus?
>
> Note that failing to mark it as cache-coherent will make the device
> rather slow and possibly not work correctly if it is in fact coherent,
> but the default is non-coherent since a lot of SoCs are lacking
> that hardware support.
Thanks for point out.
This hardware does not require dma-coherent. I will remove dma-coherent from DT
binding document.
>
> Arnd
>
Best regards,
Nobuhiro
