Hi Álvaro, Álvaro Fernández Rojas <[email protected]> wrote on Thu, 25 Feb 2021 08:54:09 +0100:
> Hi Miquel, > > > El 25 feb 2021, a las 8:48, Miquel Raynal <[email protected]> > > escribió: > > > > Hi Álvaro, > > > > Brian Norris <[email protected]> wrote on Wed, 24 Feb 2021 > > 13:01:13 -0800: > > > >> On Wed, Feb 24, 2021 at 12:02 AM Álvaro Fernández Rojas > >> <[email protected]> wrote: > >>> Fixes: 27c5b17cd1b1 ("mtd: nand: add NAND driver "library" for Broadcom > >>> STB NAND controller") > >> > >> FWIW, I could believe this was broken. We weren't testing Hamming ECC > >> (nor JFFS2) at the time, so it could easily have obvious bugs like > >> this. > > > > Right, you should probably limit the backport to the time when raw > > accessors got introduced/fixed. > > What do you mean? > Those accessors have been there since the first commit > (27c5b17cd1b10564fa36f8f51e4b4b41436ecc32): > https://github.com/torvalds/linux/blob/27c5b17cd1b10564fa36f8f51e4b4b41436ecc32/drivers/mtd/nand/brcmnand/brcmnand.c#L1896-L1899 I misunderstood Brian's answer. This commit is not that old and looks legit.
