On Fri, Mar 05, 2021 at 10:44:07AM +0000, Pho Tran wrote: > Similar to other CP210x devices, GPIO interfaces (gpiochip) should be > supported for CP2108. > > CP2108 has 4 serial interfaces but only 1 set of GPIO pins are shared to all > of those interfaces. So, just need to initialize GPIOs of CP2108 with only > one interface (I use interface 0). It means just only 1 gpiochip device file > will be created for CP2108. > > CP2108 has 16 GPIOs, So data types of several variables need to be is u16 > instead of u8(in struct cp210x_serial_private). This doesn't affect other > CP210x devices. > > Because CP2108 has 16 GPIO pins, the parameter passed by cp210x functions > will be different from other CP210x devices. So need to check part number of > the device to use correct data format before sending commands to devices. > > Like CP2104, CP2108 have GPIO pins with configurable options. Therefore, > should be mask all pins which are not in GPIO mode in cp2108_gpio_init() > function. > > Signed-off-by: Pho Tran <[email protected]<mailto:[email protected]>> > ---
This patch is whitespace corrupt. And the changelog should go here (after the '---', not after the diff). > 3/4/2021: Patch v2 Modify format patch as comment form Johan Hovold > <[email protected]<mailto:[email protected]>> As I told when you submitted a previous patch; you need to be more specific in your changelog. This doesn't say *what* has changed. > 3/1/2021: Initial submission of patch " Make the CP210x driver work > with GPIOs of CP2108 " Johan
