Hi Saravana, On 04.03.2021 20:51, Saravana Kannan wrote: > The uevents generated for an amba device need PID and CID information > that's available only when the amba device is powered on, clocked and > out of reset. So, if those resources aren't available, the information > can't be read to generate the uevents. To workaround this requirement, > if the resources weren't available, the device addition was deferred and > retried periodically. > > However, this deferred addition retry isn't based on resources becoming > available. Instead, it's retried every 5 seconds and causes arbitrary > probe delays for amba devices and their consumers. > > Also, maintaining a separate deferred-probe like mechanism is > maintenance headache. > > With this commit, instead of deferring the device addition, we simply > defer the generation of uevents for the device and probing of the device > (because drivers needs PID and CID to match) until the PID and CID > information can be read. This allows us to delete all the amba specific > deferring code and also avoid the arbitrary probing delays. > > Cc: Rob Herring <[email protected]> > Cc: Ulf Hansson <[email protected]> > Cc: John Stultz <[email protected]> > Cc: Saravana Kannan <[email protected]> > Cc: Linus Walleij <[email protected]> > Cc: Sudeep Holla <[email protected]> > Cc: Nicolas Saenz Julienne <[email protected]> > Cc: Geert Uytterhoeven <[email protected]> > Cc: Marek Szyprowski <[email protected]> > Cc: Russell King <[email protected]> > Signed-off-by: Saravana Kannan <[email protected]> > --- > > v1 -> v2: > - Dropped RFC tag > - Complete rewrite to not use stub devices. > v2 -> v3: > - Flipped the if() condition for hard-coded periphids. > - Added a stub driver to handle the case where all amba drivers are > modules loaded by uevents. > - Cc Marek after I realized I forgot to add him. > > Marek, > > Would you mind testing this? It looks okay with my limited testing.
It looks it works fine on my test systems. I've checked current linux-next and this patch. You can add: Tested-by: Marek Szyprowski <[email protected]> I've briefly scanned the code and I'm curious how does it work. Does it depend on the recently introduced "fw_devlink=on" feature? I don't see other mechanism, which would trigger matching amba device if pm domains, clocks or resets were not available on time to read pid/cid while adding a device... Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland
