Re: [PATCH] usb: typec: tcpm: turn tcpm_ams_finish into void function

[Sergei Shtylyov]

Hello!

On 08.03.2021 9:21, Yang Li wrote:

This function always return '0' and no callers use the return value.

   Returns.

So make it a void function.

This eliminates the following coccicheck warning:
./drivers/usb/typec/tcpm/tcpm.c:778:5-8: Unneeded variable: "ret".
Return "0" on line 794

Reported-by: Abaci Robot <ab...@linux.alibaba.com>
Signed-off-by: Yang Li <yang....@linux.alibaba.com>
---
  drivers/usb/typec/tcpm/tcpm.c | 6 ++----
  1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
index be0b646..6ee984e 100644
--- a/drivers/usb/typec/tcpm/tcpm.c
+++ b/drivers/usb/typec/tcpm/tcpm.c
@@ -773,10 +773,8 @@ static enum typec_cc_status tcpm_rp_cc(struct tcpm_port 
*port)
        return TYPEC_CC_RP_DEF;
  }

-static int tcpm_ams_finish(struct tcpm_port *port)

+static void tcpm_ams_finish(struct tcpm_port *port)
  {
-       int ret = 0;
-
        tcpm_log(port, "AMS %s finished", tcpm_ams_str[port->ams]);

if (port->pd_capable && port->pwr_role == TYPEC_SOURCE) {

@@ -791,7 +789,7 @@ static int tcpm_ams_finish(struct tcpm_port *port)
        port->in_ams = false;
        port->ams = NONE_AMS;

- return ret;

+       return;

   Just remove that *return*.

  }

[...]

MBR, Sergei