15.03.2021 06:35, Nicolin Chen пишет:
> This patch dumps all active mapping entries from pagetable
> to a debugfs directory named "mappings".
>
> Ataching an example:
Attaching
>
> SWGROUP: hc
> ASID: 0
> reg: 0x250
> PTB_ASID: 0xe0080004
> as->pd_dma: 0x80004000
> {
> [1023] 0xf008000b (1)
> {
> PTE RANGE | ATTR | PHYS | IOVA
> | SIZE
> [#1023, #1023] | 0x5 | 0x0000000111a8d000 |
> 0x00000000fffff000 | 0x1000
> }
> }
> Total PDE count: 1
> Total PTE count: 1
>
> Signed-off-by: Nicolin Chen <[email protected]>
> ---
Good to me, thanks.
Tested-by: Dmitry Osipenko <[email protected]>
Reviewed-by: Dmitry Osipenko <[email protected]>
> + for (pd_index = 0; pd_index < SMMU_NUM_PDE; pd_index++) {
> + struct page *pt_page;
> + u32 *addr;
> + unsigned int i;
Unimportant nit: I'd keep lines arranged by length for consistency with
the rest of the code.
...
> + group_debug = devm_kcalloc(dev, soc->num_swgroups,
> sizeof(*group_debug), GFP_KERNEL);
Another nit: this is a long line, I'd split it into two lines to keep
coding style consistent and to improve readability for those who have a
side-by-side code viewing setup.
