From: Jason Uhlenkott <[EMAIL PROTECTED]> Applied to 2.6.24-rc6-mm1
By popular request, add a comment documenting the implicit type promotion here. Signed-off-by: Jason Uhlenkott <[EMAIL PROTECTED]> Signed-off-by: Doug Thompson <[EMAIL PROTECTED] --- i3000_edac.c | 7 +++++++ 1 file changed, 7 insertions(+) Index: linux/drivers/edac/i3000_edac.c =================================================================== --- linux.orig/drivers/edac/i3000_edac.c 2008-01-14 15:16:11.137167678 -0800 +++ linux/drivers/edac/i3000_edac.c 2008-01-14 15:16:13.387855416 -0800 @@ -44,6 +44,13 @@ */ #define I3000_DEAP_GRAIN (1 << 7) +/* + * Helper functions to decode the DEAP/EDEAP hardware registers. + * + * The type promotion here is deliberate; we're deriving an + * unsigned long pfn and offset from hardware regs which are u8/u32. + */ + static inline unsigned long deap_pfn(u8 edeap, u32 deap) { deap >>= PAGE_SHIFT; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/