On Thu, Mar 18, 2021 at 09:14:03PM -0500, Josh Poimboeuf wrote: > On Thu, Mar 18, 2021 at 06:11:13PM +0100, Peter Zijlstra wrote: > > Create a common helper to add symbols. > > > > Signed-off-by: Peter Zijlstra (Intel) <pet...@infradead.org> > > --- > > tools/objtool/elf.c | 57 > > ++++++++++++++++++++++++++++++---------------------- > > 1 file changed, 33 insertions(+), 24 deletions(-) > > > > --- a/tools/objtool/elf.c > > +++ b/tools/objtool/elf.c > > @@ -290,12 +290,41 @@ static int read_sections(struct elf *elf > > return 0; > > } > > > > +static bool elf_symbol_add(struct elf *elf, struct symbol *sym) > > How about "elf_add_symbol()" for consistency with my other suggestions > (elf_add_reloc() and elf_add_string()). And return an int.
Changed the nane, how about void? This latest incarnation doesn't actually have an error path. Still doesn't hurt to have one and not use it I suppose...
