On 3/19/21 4:22 PM, Richard Gong wrote:
>
> Hi Moritz,
>
> Thanks for approving the 1st patch of my version 5 patchest, which submitted
> on 02/09/21.
This change
e23bd83368af ("firmware: stratix10-svc: fix kernel-doc markups")
Makes a lot of formatting changes in the same files as this patchset, including
the first patch.
It would be good to try applying this patchset to char-misc-next and resubmit
if there are conflicts.
>
> Can you help review the remaining 6 patches from the same version 5 patchset?
> I need your ACKs to move forward, or please let me know if additional work is
> need.
These changes look good to me.
I was looking at the patchset again seeing if the firmware/ parts could be
split out.
Even though stratix10 is a fpga, from the MAINTAINERS file it is not clear to
me if linux-fpga owns them and they come in on Moritz's branch. I think this
change is needed to the MAINTAINERS file to make that clearer.
diff --git a/MAINTAINERS b/MAINTAINERS
index aa84121c5611..1f68e9ff76de 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -9193,7 +9193,8 @@ F: tools/power/x86/intel-speed-select/
INTEL STRATIX10 FIRMWARE DRIVERS
M: Richard Gong <[email protected]>
-L: [email protected]
+R: Tom Rix <[email protected]>
+L: [email protected]
S: Maintained
F: Documentation/ABI/testing/sysfs-devices-platform-stratix10-rsu
F: Documentation/devicetree/bindings/firmware/intel,stratix10-svc.txt
I also added myself as a reviewer because I want to help out.
Tom
>
> Many thanks for your time again!
>
> Regards,
> Richard
>
>
> On 2/25/21 7:07 AM, Gong, Richard wrote:
>> Hi Moritz,
>>
>> Sorry for asking.
>>
>> When you have chance, can you help review the version 5 patchset submitted
>> on 02/09/21?
>>
>> Regards,
>> Richard
>>
>> -----Original Message-----
>> From: [email protected] <[email protected]>
>> Sent: Tuesday, February 9, 2021 4:20 PM
>> To: [email protected]; [email protected]; [email protected];
>> [email protected]; [email protected]
>> Cc: Gong, Richard <[email protected]>
>> Subject: [PATCHv5 0/7] Extend Intel service layer, FPGA manager and region
>>
>> From: Richard Gong <[email protected]>
>>
>> This is 5th submission of Intel service layer and FPGA patches, which
>> includes the missing standalone patch in the 4th submission.
>>
>> This submission includes additional changes for Intel service layer driver
>> to get the firmware version running at FPGA SoC device. Then FPGA manager
>> driver, one of Intel service layer driver's client, can decide whether to
>> handle the newly added bitstream authentication function based on the
>> retrieved firmware version. So that we can maintain FPGA manager driver the
>> back compatible.
>>
>> Bitstream authentication makes sure a signed bitstream has valid signatures.
>>
>> The customer sends the bitstream via FPGA framework and overlay, the
>> firmware will authenticate the bitstream but not program the bitstream to
>> device. If the authentication passes, the bitstream will be programmed into
>> QSPI flash and will be expected to boot without issues.
>>
>> Extend Intel service layer, FPGA manager and region drivers to support the
>> bitstream authentication feature.
>>
>> Richard Gong (7):
>> firmware: stratix10-svc: reset COMMAND_RECONFIG_FLAG_PARTIAL to 0
>> firmware: stratix10-svc: add COMMAND_AUTHENTICATE_BITSTREAM flag
>> firmware: stratix10-svc: extend SVC driver to get the firmware version
>> fpga: fpga-mgr: add FPGA_MGR_BITSTREAM_AUTHENTICATE flag
>> fpga: of-fpga-region: add authenticate-fpga-config property
>> dt-bindings: fpga: add authenticate-fpga-config property
>> fpga: stratix10-soc: extend driver for bitstream authentication
>>
>> .../devicetree/bindings/fpga/fpga-region.txt | 10 ++++
>> drivers/firmware/stratix10-svc.c | 12 ++++-
>> drivers/fpga/of-fpga-region.c | 24 ++++++---
>> drivers/fpga/stratix10-soc.c | 62
>> +++++++++++++++++++---
>> include/linux/firmware/intel/stratix10-smc.h | 21 +++++++-
>> .../linux/firmware/intel/stratix10-svc-client.h | 11 +++-
>> include/linux/fpga/fpga-mgr.h | 3 ++
>> 7 files changed, 125 insertions(+), 18 deletions(-)
>>
>> --
>> 2.7.4
>>
>
