On Thursday, 17 of January 2008, Nigel Cunningham wrote: > Hi. > > Rafael J. Wysocki wrote: > > On Thursday, 17 of January 2008, Andrew Morton wrote: > >> On Thu, 17 Jan 2008 10:36:51 -0700 Zan Lynx <[EMAIL PROTECTED]> wrote: > >> > >>> On Wed, 2008-01-16 at 22:24 -0800, Andrew Morton wrote: > >>>> So I take everyone's latest and greatest product and injudiciously type > >>>> the > >>>> above command. The result five minutes later is at > >>>> http://userweb.kernel.org/~akpm/borkage.jpg. See if you can count all > >>>> the bugs. > >>>> > >>>> Sorry, but I've had it with this stuff and I'm tired of fixing everyone > >>>> else's > >>>> stuff. I'm just going to ship it. Good luck. > >>> Heh. Laptop suspend to anything has been so broken for so long in the > >>> -mm series on my Compaq R3000 that I didn't even know it was ever > >>> supposed to work. > >> It gets broken more often than anything else. I do test each release on > >> two laptops and I get to do a lot of bisection searching and > >> grumpygramming as a result. > >> > >> Probably it would be more efficient to have the people who wrote the code > >> also test it. > > > > Well, that would certainly help. > > > > I do test all of my patches and generally all of the patches I sign off, but > > surely that's not enough. > > It is far too easy to take a cursory glance, say 'That looks okay' and > move on to the next thing, isn't it? I was horrified when I saw the list > of acks etc (including me) on the commit with the helper_unlock issue we > just fixed. It's truly scary to think that none of us looked closely > enough to pick that up at the time.
Well, the code in question was not in the patch, so if you didn't actually look at the _patched_ kmod.c, you would have a little chance to spot it. I overlooked it, even though I did look at the patched file ... Still, this particular problem hasn't been triggering it testing for quite some time. Greetings, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
