On Mon, Jan 14, 2008 at 09:05:18AM -0500, Jeff Layton wrote: > If we're shutting down all the nlm_hosts anyway, then it doesn't make > sense to allow RPC calls to linger. Allowing them to do so can mean > that the RPC calls can outlive the currently running lockd and can lead > to a use after free situation.
I assume that all new rpc calls are created by the lockd thread itself (which also calls nlm_shutdown_hosts(), which guarantees that there can't be someone about to make an rpc call using the clnt we're destroying here? By the way, any idea what the nlm_shutdown_hosts() call in exit_nlm() is doing? --b. > > Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> > --- > fs/lockd/host.c | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/fs/lockd/host.c b/fs/lockd/host.c > index 572601e..8771484 100644 > --- a/fs/lockd/host.c > +++ b/fs/lockd/host.c > @@ -377,8 +377,10 @@ nlm_shutdown_hosts(void) > /* First, make all hosts eligible for gc */ > dprintk("lockd: nuking all hosts...\n"); > for (chain = nlm_hosts; chain < nlm_hosts + NLM_HOST_NRHASH; ++chain) { > - hlist_for_each_entry(host, pos, chain, h_hash) > + hlist_for_each_entry(host, pos, chain, h_hash) { > host->h_expires = jiffies - 1; > + rpc_killall_tasks(host->h_rpcclnt); > + } > } > > /* Then, perform a garbage collection pass */ > -- > 1.5.3.7 > > - > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/