On Fri, Mar 26, 2021 at 03:18:59PM -0400, Jim Quinlan wrote: > Similar to the regulator bindings found in "rockchip-pcie-host.txt", this > allows optional regulators to be attached and controlled by the PCIe RC > driver. That being said, this driver searches in the DT subnode (the EP > node, eg pci@0,0) for the regulator property. > > The use of a regulator property in the pcie EP subnode such as > "vpcie12v-supply" depends on a pending pullreq to the pci-bus.yaml > file at > > https://github.com/devicetree-org/dt-schema/pull/54 > > Signed-off-by: Jim Quinlan <jim2101...@gmail.com> > --- > Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > index f90557f6deb8..ea3e6f55e365 100644 > --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > @@ -156,5 +156,11 @@ examples: > <0x42000000 0x1 0x80000000 0x3 0x00000000 > 0x0 0x80000000>; > brcm,enable-ssc; > brcm,scb-sizes = <0x0000000080000000 > 0x0000000080000000>; > + > + pcie-ep@0,0 { > + reg = <0x0 0x0 0x0 0x0 0x0>; > + compatible = "pci14e4,1688"; > + vpcie12v-supply: <&vreg12>;
For other cases, these properties are in the host bridge node. If these are standard PCI rails, then I think that's where they belong unless we define slot nodes. Rob
