On Wed, Apr 07, 2021 at 10:15:37PM +0800, Wong Vee Khee wrote:
> From: Tan Tee Min <tee.min....@intel.com>
>
> The Synopsis MAC controller supports auxiliary snapshot feature that
> allows user to store a snapshot of the system time based on an external
> event.
>
> This patch add supports to the above mentioned feature. Users will be
> able to triggered capturing the time snapshot from user-space using
> application such as testptp or any other applications that uses the
> PTP_EXTTS_REQUEST ioctl request.
You forgot to Cc: the PTP maintainer.
> @@ -159,6 +163,37 @@ static int stmmac_enable(struct ptp_clock_info *ptp,
> priv->systime_flags);
> spin_unlock_irqrestore(&priv->ptp_lock, flags);
> break;
> + case PTP_CLK_REQ_EXTTS:
> + priv->plat->ext_snapshot_en = on;
> + mutex_lock(&priv->aux_ts_lock);
> + acr_value = readl(ptpaddr + PTP_ACR);
> + acr_value &= ~PTP_ACR_MASK;
> + if (on) {
> + /* Enable External snapshot trigger */
> + acr_value |= priv->plat->ext_snapshot_num;
> + acr_value |= PTP_ACR_ATSFC;
> + pr_info("Auxiliary Snapshot %d enabled.\n",
> + priv->plat->ext_snapshot_num >>
> + PTP_ACR_ATSEN_SHIFT);
dev_dbg()?
> + /* Enable Timestamp Interrupt */
> + intr_value = readl(ioaddr + GMAC_INT_EN);
> + intr_value |= GMAC_INT_TSIE;
> + writel(intr_value, ioaddr + GMAC_INT_EN);
> +
> + } else {
> + pr_info("Auxiliary Snapshot %d disabled.\n",
> + priv->plat->ext_snapshot_num >>
> + PTP_ACR_ATSEN_SHIFT);
dev_dbg()?
Do you really want to spam the kernel log with this?
