On 4/6/2021 5:32 PM, Andrew Lunn wrote:
>> case PHY_INTERFACE_MODE_RGMII:
>> case PHY_INTERFACE_MODE_RGMII_ID:
>> case PHY_INTERFACE_MODE_RGMII_RXID:
>> case PHY_INTERFACE_MODE_RGMII_TXID:
>> miicfg |= GSWIP_MII_CFG_MODE_RGMII;
>> +
>> + if (phylink_autoneg_inband(mode))
>> + miicfg |= GSWIP_MII_CFG_RGMII_IBS;
>
> Is there any other MAC driver doing this? Are there any boards
> actually enabling it? Since it is so odd, if there is nothing using
> it, i would be tempted to leave this out.
Some PHYs (Broadcom namely) support suppressing the RGMII in-band
signaling towards the MAC, so if the MAC relies on that signaling to
configure itself based on what the PHY reports this may not work.
--
Florian
