On Wed, Apr 07, 2021 at 01:33:35PM -0400, min.li...@renesas.com wrote: > From: Min Li <min.li...@renesas.com> > > This driver is developed for the IDT ClockMatrix(TM) and 82P33xxx families > of timing and synchronization devices.It will be used by Renesas PTP Clock > Manager for Linux (pcm4l) software to provide support to GNSS assisted > partial timing support (APTS) and other networking timing functions. > > Current version provides kernel API's to support the following functions > -set combomode to enable SYNCE clock support > -read dpll's state to determine if the dpll is locked to the GNSS channel > -read dpll's ffo (fractional frequency offset) in ppqt > > Signed-off-by: Min Li <min.li...@renesas.com> > --- > Change log > -rebase change to linux-next tree > -remove uncessary condition checks suggested by Greg > -fix compile error for x86_64 > -register device through misc_register suggested by Greg > > drivers/misc/Kconfig | 9 ++ > drivers/misc/Makefile | 2 + > drivers/misc/rsmu_cdev.c | 266 > ++++++++++++++++++++++++++++++++++++++++++++++ > drivers/misc/rsmu_cdev.h | 74 +++++++++++++ > drivers/misc/rsmu_cm.c | 166 +++++++++++++++++++++++++++++ > drivers/misc/rsmu_sabre.c | 133 +++++++++++++++++++++++
Why do you need 4 files here? Can't you do this all in one? There's no need for such a small driver to be split up, that just causes added complexity and makes things harder to review and understand. > include/uapi/linux/rsmu.h | 64 +++++++++++ Where are you documenting these new custom ioctls? And why do you even need them? thanks, greg k-h
