On Tue, 22 Jan 2008 14:13:58 +0200, Felipe Balbi wrote: > On Jan 22, 2008 2:01 PM, Jean Delvare <[EMAIL PROTECTED]> wrote: > > On Thu, 3 Jan 2008 11:59:57 -0500, Felipe Balbi wrote: > > > - if (machine_is_omap_h2()) > > > - omap_free_gpio(2); > > > - > > > > Why? > > Board specific code should go to board files. I'll try to find a > better way of doing this. Maybe using a private_data. > Ditto to all cases below.
I agree that board code should ideally not be there, however you can't just drop it and hope nobody will notice. It needs to be done in such a way that everything still works afterwards. IMHO it is better move such changes to a later patch so as to not make this one needlessly complex. > > (Did you test you patch on OMAP H2?) > > Can't remember anymore, but before applying these patches isp1301 was > crashing the kernel on H2 and H3. That's bad, this should be fixed, if possible even before applying your patches. Thanks, -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
