Hi , > -----Original Message----- > From: Amadeusz Sławiński <amadeuszx.slawin...@linux.intel.com> > Sent: 2021年4月12日 18:40 > To: Yuan, Perry; po...@protonmail.com; pierre- > louis.boss...@linux.intel.com; oder_ch...@realtek.com; pe...@perex.cz; > ti...@suse.com; hdego...@redhat.com; mgr...@linux.intel.com > Cc: alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org; > lgirdw...@gmail.com; platform-driver-...@vger.kernel.org; > broo...@kernel.org; Dell Client Kernel; mario.limoncie...@outlook.com > Subject: Re: [PATCH v7 1/2] platform/x86: dell-privacy: Add support for Dell > hardware privacy > > > [EXTERNAL EMAIL] > > On 4/12/2021 11:19 AM, Perry Yuan wrote: > > From: Perry Yuan <perry_y...@dell.com> > > > > (...) > > > diff --git a/drivers/platform/x86/dell/dell-laptop.c > > b/drivers/platform/x86/dell/dell-laptop.c > > index 70edc5bb3a14..e7ffc0b81208 100644 > > --- a/drivers/platform/x86/dell/dell-laptop.c > > +++ b/drivers/platform/x86/dell/dell-laptop.c > > @@ -31,6 +31,8 @@ > > #include "dell-rbtn.h" > > #include "dell-smbios.h" > > > > +#include "dell-privacy-wmi.h" > > + > > struct quirk_entry { > > bool touchpad_led; > > bool kbd_led_not_present; > > @@ -90,6 +92,7 @@ static struct rfkill *wifi_rfkill; > > static struct rfkill *bluetooth_rfkill; > > static struct rfkill *wwan_rfkill; > > static bool force_rfkill; > > +static bool has_privacy; > > > > module_param(force_rfkill, bool, 0444); > > MODULE_PARM_DESC(force_rfkill, "enable rfkill on non whitelisted > > models"); @@ -2206,10 +2209,16 @@ static int __init dell_init(void) > > > > if (dell_smbios_find_token(GLOBAL_MIC_MUTE_DISABLE) && > > dell_smbios_find_token(GLOBAL_MIC_MUTE_ENABLE)) { > > - micmute_led_cdev.brightness = > ledtrig_audio_get(LED_AUDIO_MICMUTE); > > - ret = led_classdev_register(&platform_device->dev, > &micmute_led_cdev); > > - if (ret < 0) > > - goto fail_led; > > + if (dell_privacy_present()) > > + has_privacy = true; > > + else > > + has_privacy = false; > > Bit, of nitpicking, but you can write above shorter: > has_privacy = dell_privacy_present();
Good point, changed the code as you suggested. Thank you. Perry.