We should return an error code if the timing mode is not acknowledged
by the NAND chip.

Fixes: 415ae78ffb5d ("mtd: rawnand: check ONFI timings have been acked by the 
chip")
Signed-off-by: Dan Carpenter <[email protected]>
---
>From static analysis.  Not tested.

 drivers/mtd/nand/raw/nand_base.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
index fb072c444495..d83c0503f96f 100644
--- a/drivers/mtd/nand/raw/nand_base.c
+++ b/drivers/mtd/nand/raw/nand_base.c
@@ -880,6 +880,7 @@ static int nand_setup_interface(struct nand_chip *chip, int 
chipnr)
        if (tmode_param[0] != chip->best_interface_config->timings.mode) {
                pr_warn("timing mode %d not acknowledged by the NAND chip\n",
                        chip->best_interface_config->timings.mode);
+               ret = -EINVAL;
                goto err_reset_chip;
        }
 
-- 
2.30.2

Reply via email to