On Thu, 15 Apr 2021, Ian Abbott wrote:
> On 14/04/2021 19:11, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/staging/comedi/drivers/jr3_pci.c: In function
> > ‘jr3_pci_poll_subdevice’:
> > drivers/staging/comedi/drivers/jr3_pci.c:507:22: warning: variable
> > ‘min_full_scale’ set but not used [-Wunused-but-set-variable]
> >
> > Cc: Ian Abbott <abbo...@mev.co.uk>
> > Cc: H Hartley Sweeten <hswee...@visionengravers.com>
> > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
> > Cc: "Alexander A. Klimov" <grandmas...@al2klimov.de>
> > Cc: Anders Blomdell <anders.blomd...@control.lth.se>
> > Cc: linux-stag...@lists.linux.dev
> > Signed-off-by: Lee Jones <lee.jo...@linaro.org>
> > ---
> > drivers/staging/comedi/drivers/jr3_pci.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/comedi/drivers/jr3_pci.c
> > b/drivers/staging/comedi/drivers/jr3_pci.c
> > index 7a02c4fa3cda8..afa2f8d5c8c0c 100644
> > --- a/drivers/staging/comedi/drivers/jr3_pci.c
> > +++ b/drivers/staging/comedi/drivers/jr3_pci.c
> > @@ -504,10 +504,9 @@ jr3_pci_poll_subdevice(struct comedi_subdevice *s)
> > result = poll_delay_min_max(20, 100);
> > } else {
> > /* Set full scale */
> > - struct six_axis_t min_full_scale;
> > struct six_axis_t max_full_scale;
> > - min_full_scale = get_min_full_scales(sensor);
> > + get_min_full_scales(sensor);
> > max_full_scale = get_max_full_scales(sensor);
> > set_full_scales(sensor, max_full_scale);
> >
>
> get_min_full_scales() could be removed altogether. It was only being called
> originally so the driver could printk the values, but those printks have
> since been removed.
Even better. Thanks Ian.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
