在 2024/6/17 23:07, Dragos Tatulea 写道:
Start using the suspend/resume_vq() error return codes previously added.

Signed-off-by: Dragos Tatulea <dtatu...@nvidia.com>
Reviewed-by: Cosmin Ratiu <cra...@nvidia.com>
---
  drivers/vdpa/mlx5/net/mlx5_vnet.c | 12 ++++++++----
  1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c 
b/drivers/vdpa/mlx5/net/mlx5_vnet.c
index f5d5b25cdb01..0e1c1b7ff297 100644
--- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
+++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
@@ -3436,22 +3436,25 @@ static int mlx5_vdpa_suspend(struct vdpa_device *vdev)
  {
        struct mlx5_vdpa_dev *mvdev = to_mvdev(vdev);
        struct mlx5_vdpa_net *ndev = to_mlx5_vdpa_ndev(mvdev);
+       int err;

Reverse Christmas Tree?

Reviewed-by: Zhu Yanjun <yanjun....@linux.dev>

Zhu Yanjun
mlx5_vdpa_info(mvdev, "suspending device\n"); down_write(&ndev->reslock);
        unregister_link_notifier(ndev);
-       suspend_vqs(ndev);
+       err = suspend_vqs(ndev);
        mlx5_vdpa_cvq_suspend(mvdev);
        mvdev->suspended = true;
        up_write(&ndev->reslock);
-       return 0;
+
+       return err;
  }
static int mlx5_vdpa_resume(struct vdpa_device *vdev)
  {
        struct mlx5_vdpa_dev *mvdev = to_mvdev(vdev);
        struct mlx5_vdpa_net *ndev;
+       int err;
ndev = to_mlx5_vdpa_ndev(mvdev); @@ -3459,10 +3462,11 @@ static int mlx5_vdpa_resume(struct vdpa_device *vdev) down_write(&ndev->reslock);
        mvdev->suspended = false;
-       resume_vqs(ndev);
+       err = resume_vqs(ndev);
        register_link_notifier(ndev);
        up_write(&ndev->reslock);
-       return 0;
+
+       return err;
  }
static int mlx5_set_group_asid(struct vdpa_device *vdev, u32 group,



Reply via email to