On Jan 31, 2008 5:48 AM, David Brownell <[EMAIL PROTECTED]> wrote: > On Wednesday 30 January 2008, Bryan Wu wrote: > > When got some gpio conflict, it is easy to know which SPI device driver not > > just got "bfin-spi" > > > > Signed-off-by: Bryan Wu <[EMAIL PROTECTED]> > > --- > > drivers/spi/spi_bfin5xx.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/spi/spi_bfin5xx.c b/drivers/spi/spi_bfin5xx.c > > index 8fd1365..c3f9ed4 100644 > > --- a/drivers/spi/spi_bfin5xx.c > > +++ b/drivers/spi/spi_bfin5xx.c > > @@ -1176,7 +1176,7 @@ static int setup(struct spi_device *spi) > > if ((chip->chip_select_num > 0) > > && (chip->chip_select_num <= spi->master->num_chipselect)) > > peripheral_request(ssel[spi->master->bus_num] > > - [chip->chip_select_num-1], DRV_NAME); > > + [chip->chip_select_num-1], spi->modalias); > > Better: spi->dev.bus_id (always unique) not spi->modalias (isn't) ... >
spi->dev.bus_id is just number, while spi->modalias usually is a string name which it is more meaningful. In most time, modalias is easier for us to locate the gpio conflict. Thanks -Bryan Wu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/