On 5/20/25 12:57, Jarkko Sakkinen wrote: > unlikely() is both (minor) optimization and documents that it is not expected > branch so it obviously makes sense here.
I'm not a big fan of unlikely() being thrown in without specific reasons. I don't think we need an annotation to tell us that the path that spits out a warning is not the common path. I'm also pretty sure the compiler doesn't need any help. In this case, it is pure noise.
