On Fri, Jun 27, 2025 at 12:05:08PM +0200, Luca Weiss wrote: > On Wed Jun 25, 2025 at 11:03 PM CEST, Dmitry Baryshkov wrote: > > On Wed, Jun 25, 2025 at 05:01:29PM +0200, Luca Weiss wrote: > >> On Wed Jun 25, 2025 at 4:25 PM CEST, Dmitry Baryshkov wrote: > >> > On Wed, Jun 25, 2025 at 11:18:36AM +0200, Luca Weiss wrote: > >> >> The PMXR2230 PMIC is used in conjuction with SM7635. Add binding docs > >> >> and the devicetree description for it. > >> > > >> > > >> > Please use PM7550 instead. > >> > >> I'm happy to not follow downstream naming conventions if being told, but > >> do you have any details whether PMXR2230 == PM7550, or PM7550 is just > >> another SW-compatible PMIC as PMXR2230. > > > > It is PM7550. > > Ok, will update in v2. > > > > >> > >> Also we already have qcom,pmxr2230-gpio upstream, so that would need to > >> get updated for the PM7550 name. > > > > No, leave it be. We should not change existing compats for no reason. > > The compatible is not used in upstream dts though, and cleaning up some > old naming for the PMIC would be good, no?
Then, I'd say, just use pm7550 everywhere, making the qcom,pmxr2230-gpio a one-off unused entry, which we might drop at some point. > > But I can leave it for now, and we can potentially take care of it > later. > > Regards > Luca > > > > >> > >> Regards > >> Luca > >> > >> > > >> >> > >> >> Signed-off-by: Luca Weiss <luca.we...@fairphone.com> > >> >> --- > >> >> Luca Weiss (3): > >> >> dt-bindings: leds: qcom,spmi-flash-led: Add PMXR2230 > >> >> dt-bindings: mfd: qcom-spmi-pmic: Document PMXR2230 PMIC > >> >> arm64: dts: qcom: Add PMXR2230 PMIC > >> >> > >> >> .../bindings/leds/qcom,spmi-flash-led.yaml | 1 + > >> >> .../devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 1 + > >> >> arch/arm64/boot/dts/qcom/pmxr2230.dtsi | 63 > >> >> ++++++++++++++++++++++ > >> >> 3 files changed, 65 insertions(+) > >> >> --- > >> >> base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494 > >> >> change-id: 20250620-sm7635-pmxr2230-ee55a86a8c2b > >> >> > >> >> Best regards, > >> >> -- > >> >> Luca Weiss <luca.we...@fairphone.com> > >> >> > >> > -- With best wishes Dmitry
