On 01/07/2025 12:16, Luca Weiss wrote: >>> - if: >>> properties: >>> compatible: >>> @@ -185,6 +205,7 @@ allOf: >>> compatible: >>> contains: >>> enum: >>> + - qcom,sm7635-adsp-pas >>> - qcom,sm8550-adsp-pas >>> - qcom,sm8650-adsp-pas >>> - qcom,sm8750-adsp-pas >> >> sm6350 fits, doesn't it? > > Not quite, for sure the firmware-name and memory-region for adsp and > cdsp on this SoC requires the dtb firmware file as well, apart from that > it looks similar enough.
I looked briefly, so indeed it might not fit well. That's on you to investigate and find the best candidate which will mean the least amount of changes or the simplest binding. > > I'm also okay with creating a new (after the whole renaming thing) > qcom,milos-pas.yaml which contains the bindings for all 4 *-pas'es. If it does not fit sm6350 or others then yes, new binding it is. Best regards, Krzysztof
