Ingo Molnar wrote:
* Harvey Harrison <[EMAIL PROTECTED]> wrote:
case 1:
- *(unsigned char *)s = pattern;
+ *(unsigned char *)s = pattern & 0xff;
i've applied your fix - but wouldnt it be cleaner to just cast the
pattern variable to unsigned char instead?
Even better, since we're talking about fixed bytes, I suggest writing it as:
*(u8 *)s = (u8)pattern;
Much more compact and the intent is a little bit more obvious.
-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
