On Mon, Jul 21, 2025 at 01:38:59PM +0200, Krzysztof Kozlowski wrote: >On 21/07/2025 08:42, Peng Fan wrote: >>> + >>> + interrupt-names: >>> + minItems: 6 >>> + maxItems: 6 >> >> Ditto. >> >> Do you need to define the list? > > >Did you read the entire binding? It reminds me Frank's comment as well -
I DO. >instead of actually checking you just ask question which you would find >answer by yourselves if you really opened the code. I see there is a list in pas-common with entries listed. So just wonder here is there a need to list all 6 entries. Not qcom developer, just go through the list and see what I could do. Things could be improved if ask language is not welcomed. Or I am doing something wrong here? > >> >>> + >>> + qcom,qmp: >>> + $ref: /schemas/types.yaml#/definitions/phandle >>> + description: Reference to the AOSS side-channel message RAM. >>> + >>> + smd-edge: false >>> + >>> + firmware-name: >>> + $ref: /schemas/types.yaml#/definitions/string-array >>> + minItems: 1 >>> + items: >>> + - description: Firmware name of the Hexagon core >>> + - description: Firmware name of the Hexagon Devicetree >>> + >>> + memory-region: >>> + minItems: 1 >>> + items: >>> + - description: Memory region for core Firmware authentication >>> + - description: Memory region for Devicetree Firmware authentication >>> + >>> +required: >>> + - compatible >>> + - reg >>> + - memory-region >>> + >>> +allOf: >>> + - $ref: /schemas/remoteproc/qcom,pas-common.yaml# >>> + - if: >>> + properties: >>> + compatible: >>> + enum: >>> + - qcom,milos-adsp-pas >>> + - qcom,milos-cdsp-pas >>> + then: >>> + properties: >>> + memory-region: >>> + minItems: 2 >>> + maxItems: 2 >>> + firmware-name: >>> + minItems: 2 >>> + maxItems: 2 >> >> Just keep minItems if maxItems is same value. > > >This is not a correct advice. Sorry for this. I may need to find out more in dt-schema. Regards, Peng > > >Best regards, >Krzysztof
