On Tue, Oct 07, 2025 at 11:16:28PM +0100, Bryan O'Donoghue wrote:
> On 07/10/2025 22:23, Manivannan Sadhasivam wrote:
> > > +void qcom_scm_pas_context_destroy(struct qcom_scm_pas_context *ctx)
> > > +{
> > > + kfree(ctx->metadata);
> > > + ctx->metadata = NULL;
> > > + ctx->dev = NULL;
> > > + ctx->pas_id = 0;
> > > + ctx->mem_phys = 0;
> > > + ctx->mem_size = 0;
> > Why do you need to zero initialize these fields before freeing? Are they
> > carrying any sensitive data that warrants zero initialization?Nothing special about the data. > > Mukesh, have to say I don't think adding my RB to this patch is really > warranted. > > I gave review feedback that the above looked odd. > > https://lore.kernel.org/linux-arm-msm/[email protected] > > Could you please drop my RB here, and fix the above in your next version. Sorry if I misunderstood your comment on this particular patch. I assumed your concern was regarding the manual destroy call, and I responded to that point. Since I didn’t receive a follow-up on that, I proceeded to address all other comments and added your Reviewed-by tag. However, since we are revisiting this discussion, it seems appropriate to remove the destroy function altogether and switch to using devm_ APIs. > > Also please add me to the cc list for the whole series. Will surely do it, thanks. > > --- > bod -- -Mukesh Ojha
