On Sun, 21 Dec 2025 12:00:21 +0800 Chunyu Hu <[email protected]> wrote:
> Patch series "Fix va_high_addr_switch.sh test failure - again", v2. > > The series address several issues exist for the va_high_addr_switch test: > 1) the test return value is ignored in va_high_addr_switch.sh. > 2) the va_high_addr_switch test requires 6 hugepages not 5. > 3) the reurn value of the first test in va_high_addr_switch.c can be > overridden by the second test. > 4) the nr_hugepages setup in run_vmtests.sh for arm64 can be done in > va_high_addr_switch.sh too. > 5) update a comment for check_test_requirements. > > Changes in v2: > - shorten the comment in for hugepages setup in v1 > - add a new patch to fix the return value overridden issue in > va_high_addr_switch.c > - fix a code comment for check_test_requirements. > - update the series summary in patch 1 > - add reviewed-by from Luiz Capitulino on patch 1 and patch 3 The "Changes in v2" material is best placed below the "---" separator - I prefer not to capture such short-term development-time info within the permanent kernel record. > This patch: (of 5) > > The return value should be return value of va_high_addr_switch, otherwise > a test failure would be silently ignored. > > Reviewed-by: Luiz Capitulino <[email protected]> > Fixes: d9d957bd7b61 ("selftests/mm: alloc hugepages in va_high_addr_switch > test") > CC: Luiz Capitulino <[email protected]> > Signed-off-by: Chunyu Hu <[email protected]> > > ... > > According to the doc below, I don't add the cover letter, not sure if cover > letter is preferred, and if that's the case, the doc need an update. Funnily enough, your series was in the exact format which I use when committing patch series. Usually people put the cover letter in a separate [0/N] email and I move that into the [1/N] patch's changelog, as you've done here. > https://www.ozlabs.org/~akpm/stuff/tpp.txt God does that still exist? Pretty soon it will be able to legally drink in bars. I think its content got absorbed into a Documentation/ file a long time ago!
