On Wed, 30 Jan 2008 18:30:52 +0800 Zhang Wei <[EMAIL PROTECTED]> wrote:
>
> -void fsl_rio_setup(int law_start, int law_size)
> +int fsl_rio_setup(struct of_device *dev)
> {
> + if (!dev->node) {
> + dev_err(&dev->dev, "Device OF-Node is NULL");
> + return -EFAULT;
Probably -EINVAL would be better. Here and all the other -EFAULTs.
> + aw = *(u32 *)of_get_property(dev->node, "#address-cells", NULL);
> + sw = *(u32 *)of_get_property(dev->node, "#size-cells", NULL);
What happens if either of these properties is missing?
> +static struct of_device_id fsl_of_rio_rpn_ids[] = {
This should be "const" please.
--
Cheers,
Stephen Rothwell [EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgp5nmctM9RR0.pgp
Description: PGP signature
