On 18/02/2026 12:01, Matthieu Baerts (NGI0) wrote:
> The verification signature header generation requires converting a
> binary certificate to a C array. Previously this only worked with xxd,
> and a switch to hexdump has been done in commit b640d556a2b3
> ("selftests/bpf: Remove xxd util dependency").
>
> hexdump is a more common utility program, yet it might not be installed
> by default. When it is not installed, BPF selftests build without
> errors, but tests_progs is unusable: it exits with the 255 code and
> without any error messages. When manually reproducing the issue, it is
> not too hard to find out that the generated verification_cert.h file is
> incorrect, but that's time consuming. When digging the BPF selftests
> build logs, this line can be seen amongst thousands others, but ignored:
>
> /bin/sh: 2: hexdump: not found
>
> Here, od is used instead of hexdump. od is coming from the coreutils
> package, and this new od command produces the same output when using od
> from GNU coreutils, uutils, and even busybox. This is more portable, and
> it produces a similar results to what was done before with hexdump:
> there is an extra comma at the end instead of trailing whitespaces,
> but the C code is not impacted.
>
> Fixes: b640d556a2b3 ("selftests/bpf: Remove xxd util dependency")
> Signed-off-by: Matthieu Baerts (NGI0) <[email protected]>
looks good to me, and works well.
Tested-by: Alan Maguire <[email protected]>
