On 06/03/2026 15:03, Shawn Guo wrote:
> The type of firmware-name is already defined by core schemas.  Some of
> qcom remoteproc bindings define it redundantly, while others do not.
> Drop it to be consistent and avoid it being copied over to new files.
> 
> Signed-off-by: Shawn Guo <[email protected]>
> ---
>  .../devicetree/bindings/remoteproc/qcom,msm8916-mss-pil.yaml     | 1 -
>  .../devicetree/bindings/remoteproc/qcom,msm8996-mss-pil.yaml     | 1 -
>  .../devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml         | 1 -
>  .../devicetree/bindings/remoteproc/qcom,sc7180-mss-pil.yaml      | 1 -
>  .../devicetree/bindings/remoteproc/qcom,sc7280-mss-pil.yaml      | 1 -
>  .../devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml        | 1 -
>  Documentation/devicetree/bindings/remoteproc/qcom,sdx55-pas.yaml | 1 -
>  .../devicetree/bindings/remoteproc/qcom,sm8550-pas.yaml          | 1 -

I was fixing all remoteprocs here:
https://lore.kernel.org/all/[email protected]/#r

so I am a bit confused how I missed these. Maybe at that time the
dtschema did not have definition and I postponed fixing these for later?

And then more wrong addons like sa8775p appeared...


> -    $ref: /schemas/types.yaml#/definitions/string-array
>      items:
>        - description: Name of MBA firmware
>        - description: Name of modem firmware
> diff --git 
> a/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml 
> b/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml
> index 5dbda3a55047..63ae3a30f626 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml
> @@ -42,7 +42,6 @@ properties:
>      description: Reference to the reserved-memory for the Hexagon core
>  
>    firmware-name:
> -    $ref: /schemas/types.yaml#/definitions/string
>      description: Firmware name for the Hexagon core

This and other needs fixes, look at my commit.

Best regards,
Krzysztof

Reply via email to