On Thu, Mar 12, 2026 at 08:27:33AM +0000, cristian_ci wrote: > On Sunday, March 8th, 2026 at 20:27, Dmitry Baryshkov > <[email protected]> wrote: > > > On Sun, Mar 08, 2026 at 04:52:42PM +0100, Cristian Cozzolino via B4 Relay > > wrote: > > > From: Cristian Cozzolino <[email protected]> > > > + > > > +static int nt35532_on(struct novatek_nt35532 *ctx) > > > +{ > > > + struct mipi_dsi_multi_context dsi_ctx = { .dsi = ctx->dsi }; > > > + > > > + mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xff, 0x01); > > > + mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0x6e, 0x80); > > > + mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0x68, 0x13); > > > + mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xfb, 0x01); > > > + mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xff, 0x02); > > > > If this goes to be resent for any reason, could you please insert an > > empty line before 0xff, 0xNN wries? > > Just to be sure about such request, should I add a blank line before: > > mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xff, 0x02); > > , before: > > mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xff, 0x05); > > , before: > > mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xff, 0x01); > > and so on...?
Yes > > > > + mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0xfb, 0x01); > > > > [...] > > > > > + mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0x11, 0x00); > > > > I suppose this is MIPI_DCS_EXIT_SLEEP_MODE, > > > > > + mipi_dsi_msleep(&dsi_ctx, 120); > > > + mipi_dsi_generic_write_seq_multi(&dsi_ctx, 0x29, 0x00); > > > > MIPI_DCS_SET_DISPLAY_ON > > I've done a double-check through NT35532 datasheet and > include/video/mipi_display.h: instruction codes match exactly > those mipi dcs command enum item names you've mentioned. > So, would I have something like: > > mipi_dsi_generic_write_seq_multi(&dsi_ctx, MIPI_DCS_EXIT_SLEEP_MODE, 0x00); > > mipi_dsi_generic_write_seq_multi(&dsi_ctx, MIPI_DCS_SET_DISPLAY_ON, 0x00); > > ? Yes, thank you. > > > > + mipi_dsi_msleep(&dsi_ctx, 50); > > > + > > > + return dsi_ctx.accum_err; > > > +} > > > + > > > > -- > > With best wishes > > Dmitry > > -- With best wishes Dmitry
