On 4/3/26 08:27, Harry Yoo (Oracle) wrote: >> diff --git a/include/linux/slab.h b/include/linux/slab.h >> index 15a60b501b95..c0bf00ee6025 100644 >> --- a/include/linux/slab.h >> +++ b/include/linux/slab.h >> @@ -864,10 +877,10 @@ unsigned int kmem_cache_sheaf_size(struct slab_sheaf >> *sheaf); >> * with the exception of kunit tests >> */ >> >> -void *__kmalloc_noprof(size_t size, gfp_t flags) >> +void *__kmalloc_noprof(size_t size, gfp_t flags, kmalloc_token_t token) >> __assume_kmalloc_alignment __alloc_size(1); >> >> -void *__kmalloc_node_noprof(DECL_BUCKET_PARAMS(size, b), gfp_t flags, int >> node) >> +void *__kmalloc_node_noprof(DECL_BUCKET_PARAMS(size, b), gfp_t flags, int >> node, kmalloc_token_t token) >> __assume_kmalloc_alignment __alloc_size(1); > > So the @token parameter is unused when CONFIG_PARTITION_KMALLOC_CACHES is > disabled but still increases the kernel size by a few kilobytes... > but yeah I'm not sure if we can get avoid it without hurting readability. > > Just saying. (does anybody care?)
Well we did care enough with CONFIG_SLAB_BUCKETS to hide the unused param using DECL_BUCKET_PARAMS(), so maybe extend that idea? I think it's not just kernel size, but increased register pressure etc.
