Fix NULL dereference when cloning a symbol from an empty section.
sec->data is only populated for sections with non-zero size.

Fixes: dd590d4d57eb ("objtool/klp: Introduce klp diff subcommand for diffing 
object files")
Signed-off-by: Josh Poimboeuf <[email protected]>
---
 tools/objtool/klp-diff.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/objtool/klp-diff.c b/tools/objtool/klp-diff.c
index 7f6f86117394..3303664a39d7 100644
--- a/tools/objtool/klp-diff.c
+++ b/tools/objtool/klp-diff.c
@@ -696,7 +696,7 @@ static struct symbol *__clone_symbol(struct elf *elf, 
struct symbol *patched_sym
                        size_t size;
 
                        /* bss doesn't have data */
-                       if (patched_sym->sec->data->d_buf)
+                       if (patched_sym->sec->data && 
patched_sym->sec->data->d_buf)
                                data = patched_sym->sec->data->d_buf + 
patched_sym->offset;
 
                        if (is_sec_sym(patched_sym))
-- 
2.53.0


Reply via email to