On Wed, Apr 22, 2026 at 9:04 PM Josh Poimboeuf <[email protected]> wrote: > > While there was once a section named .data.once, it has since been > renamed to .data..once with commit dbefa1f31a91 ("Rename .data.once to > .data..once to fix resetting WARN*_ONCE"). Fix it. > > Fixes: dd590d4d57eb ("objtool/klp: Introduce klp diff subcommand for diffing > object files") > Signed-off-by: Josh Poimboeuf <[email protected]>
Acked-by: Song Liu <[email protected]> Nitpick: shall we match both ".data.once" and ".data..once", so that whoever backports klp-build to older kernels will not have a surprise. > --- > tools/objtool/klp-diff.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/objtool/klp-diff.c b/tools/objtool/klp-diff.c > index b1b068e9b4c7..cb26c1c92a74 100644 > --- a/tools/objtool/klp-diff.c > +++ b/tools/objtool/klp-diff.c > @@ -257,7 +257,8 @@ static bool is_uncorrelated_static_local(struct symbol > *sym) > if (!is_object_sym(sym) || !is_local_sym(sym)) > return false; > > - if (!strcmp(sym->sec->name, ".data.once")) > + /* WARN_ONCE, etc */ > + if (!strcmp(sym->sec->name, ".data..once")) > return true; > > dot = strchr(sym->name, '.'); > -- > 2.53.0 > >
